Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: streamlined and unified README.md badges #1154

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Standardizes README.md badges to have the emoji at the start because I want them consistent and the npm version badge can't have the emoji tacked on.

Streamlines them by removing the sponsor and style badges and trimming the code of conduct badge down to say kept instead of _enforced. This means they should all fit on one line in the npm site.

Also fixes a bug in findExistingBadges where matchers were being re-created then looped on, instead of re-created each instance of the loop. /g regexp state matters!

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01704e9) 94.32% compared to head (ba3b655) 94.30%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
- Coverage   94.32%   94.30%   -0.02%     
==========================================
  Files          99       99              
  Lines        5676     5657      -19     
  Branches      462      460       -2     
==========================================
- Hits         5354     5335      -19     
  Misses        321      321              
  Partials        1        1              
Flag Coverage Δ
create 70.22% <73.07%> (-0.05%) ⬇️
initialize 42.46% <0.00%> (+0.14%) ⬆️
migrate 69.64% <100.00%> (-0.11%) ⬇️
unit 72.27% <96.15%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6daf043 into main Dec 31, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the streamlined-unified-readme-badges branch December 31, 2023 19:02
Copy link

🎉 This is included in version v1.52.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Repository badges are out-of-date compared to the template
1 participant