Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't || exit 0 in cleanup build #1161

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Removes the || exit 0 per the issue.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (378d1b0) 94.30% compared to head (dae2a01) 94.30%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1161   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files          99       99           
  Lines        5657     5657           
  Branches      460      459    -1     
=======================================
  Hits         5335     5335           
  Misses        321      321           
  Partials        1        1           
Flag Coverage Δ
create 70.22% <0.00%> (ø)
initialize 42.46% <0.00%> (ø)
migrate 69.64% <0.00%> (ø)
unit 72.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit c5e15e4 into main Dec 31, 2023
17 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the cleanup-build-no-exit-0 branch December 31, 2023 21:48
@JoshuaKGoldberg
Copy link
Owner Author

whoops. fixes #1160.

Copy link

🎉 This is included in version v1.52.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant