Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preserve existing unknown .github/DEVELOPMENT.md sections #1173

Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 1, 2024

PR Checklist

Overview

Now, when .github/DEVELOPMENT.md exists, any ## that doesn't match the new headings will be preserved and moved to the bottom of the file.

Note that this doesn't show up nicely in the migration test end-to-end snapshots because updateLocalFiles manually removes the ## Setup Scripts sections.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a21348a) 94.69% compared to head (50a4ed1) 94.78%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   94.69%   94.78%   +0.09%     
==========================================
  Files         102      104       +2     
  Lines        5689     5775      +86     
  Branches      468      482      +14     
==========================================
+ Hits         5387     5474      +87     
+ Misses        301      300       -1     
  Partials        1        1              
Flag Coverage Δ
create 70.34% <76.11%> (+0.08%) ⬆️
initialize 42.34% <23.38%> (-0.14%) ⬇️
migrate 70.24% <90.04%> (+0.42%) ⬆️
unit 74.42% <92.53%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 9, 2024 17:15
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5cd4a95 into main Jan 9, 2024
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the migrate-preserve-existing-development-sections branch January 9, 2024 17:22
Copy link

🎉 This is included in version v1.54.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: In --mode migrate, preserve existing .github/DEVELOPMENT.md body contents
1 participant