Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Build failures on main > contributors: "fetch is not set" #1227

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 9, 2024 · 5 comments
Closed
3 tasks done
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 9, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

From https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/7500363646/job/20418893198:

Run JoshuaKGoldberg/all-contributors-auto-action@v0.4.2
file:///home/runner/work/_actions/JoshuaKGoldberg/all-contributors-auto-action/v0.4.2/dist/index.js:10178
    throw new Error(
          ^

Error: fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing
    at fetchWrapper (file:///home/runner/work/_actions/JoshuaKGoldberg/all-contributors-auto-action/v0.4.2/dist/index.js:10178:11)
    at request2 (file:///home/runner/work/_actions/JoshuaKGoldberg/all-contributors-auto-action/v0.4.2/dist/index.js:10293:14)
    at hook (file:///home/runner/work/_actions/JoshuaKGoldberg/all-contributors-auto-action/v0.4.2/dist/index.js:4924:10)
    at async requestWithGraphqlErrorHandling (file:///home/runner/work/_actions/JoshuaKGoldberg/all-contributors-auto-action/v0.4.2/dist/index.js:9719:20)
    at async Job.doExecute (file:///home/runner/work/_actions/JoshuaKGoldberg/all-contributors-auto-action/v0.4.2/dist/index.js:117[5](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/7500363646/job/20418893198#step:4:6)4:1[8](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/7500363646/job/20418893198#step:4:9))

...is the Action not being run in Node >=18? I thought they all should be...

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Jan 9, 2024
@JoshuaKGoldberg
Copy link
Owner Author

Huh. Definitely being run in Node >=18:

Run actions/setup-node@v4
  with:
    cache: pnpm
    node-version: 18
    always-auth: false
    check-latest: false
    token: ***
  env:
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
Found in cache @ /opt/hostedtoolcache/node/18.19.0/x64
Environment details
  node: v18.19.0
  npm: 10.2.3
  yarn: 1.22.21

@JoshuaKGoldberg
Copy link
Owner Author

all-contributors-for-repository is on octokit@3.0.0 right now: https://github.com/JoshuaKGoldberg/all-contributors-for-repository/blob/d24447e2f1ff4081f275b5d80da50f638c4cc2f8/pnpm-lock.yaml#L19. The latest is 3.1.2. I'll try upgrading packages to latest before filing an issue.

@JoshuaKGoldberg
Copy link
Owner Author

Well, that didn't fix it. Nor Node 20. Very confusing.

@JoshuaKGoldberg
Copy link
Owner Author

@JoshuaKGoldberg
Copy link
Owner Author

Fixed in 45f4b78 here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

1 participant