feat: added events option with onClick #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Replaces the
tagName
option with anevents
object. So far, per #136, it just has anonClick
optional property.This notably means that users are now provided the
actor: EmojiActor
for the first (intentional) time ever. Actors now have anupdate()
function that can take in a newopacity
and/orvelocity
. Applies a couple of refactors in support of that:Animator
class to just ananimate
function, since there was no reason to expose thestart
ortick
methods to consumers before#
privates withget
ters on top of them, so that the types can mark them asReadonly<...>
One nifty thing is the
domNodesToActors: WeakMap<EventTarget, EmojiActor>
. It maps from click event targets back to the emoji actor in the library.