Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect example in 'sort-collections' #137

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: incorrect example in 'sort-collections' #137

merged 1 commit into from
Jan 25, 2024

Conversation

KristjanESPERANTO
Copy link
Contributor

PR Checklist

Overview

Deactivation of the sorting rule so that the incorrect example remains incorrect after linting.

🌱

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 25, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️‍🔥 flawless. Thanks @KristjanESPERANTO!

@JoshuaKGoldberg
Copy link
Owner

🌱

Great emoji by the way. 😄

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e8b6fb) 99.30% compared to head (6c653bd) 99.30%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          14       14           
  Lines         865      865           
  Branches       74       74           
=======================================
  Hits          859      859           
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 88a94a0 into JoshuaKGoldberg:main Jan 25, 2024
14 of 15 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @KristjanESPERANTO for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Jan 25, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @KristjanESPERANTO! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.10.1 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Jan 25, 2024
@allcontributors
docs: add kristjanesperanto as a contributor for code (#139)
31b8970 
Adds @KristjanESPERANTO as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#137 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Documentation: Incorrect example in 'sort-collections' is correct
2 participants
@KristjanESPERANTO @JoshuaKGoldberg