Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can not import in ESM package #159

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: can not import in ESM package #159

merged 1 commit into from
Feb 20, 2024

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Feb 20, 2024 •
edited
Loading

PR Checklist

Overview

related #157

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d9ed75) 99.30% compared to head (612377f) 99.30%.
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          15       15           
  Lines         866      866           
  Branches       73       73           
=======================================
  Hits          860      860           
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 20, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks! I appreciate you working with me on this! 🥰

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2ce1881 into JoshuaKGoldberg:main Feb 20, 2024
17 checks passed
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.10.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Can not import this in ESM package
2 participants
@hyoban @JoshuaKGoldberg