Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃洜 Tooling: Make sure no file in the repo contains "josh" or "template-typescript-node-package" in end-to-end setup test #157

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 24, 2022 · 0 comments 路 Fixed by #283
Closed
3 tasks done

馃洜 Tooling: Make sure no file in the repo contains "josh" or "template-typescript-node-package" in end-to-end setup test #157

JoshuaKGoldberg opened this issue Dec 24, 2022 · 0 comments 路 Fixed by #283
Assignees
@JoshuaKGoldberg
Labels
area: testing Improving how the repository's tests are run and/or code is tested area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

In #146, I added an "end-to-end" test script/setup-test-e2e.js for the setup script. It tests that some basic aspects of the script are as expected: that the script doesn't crash, and that it updates a couple values in package.json. More aspects should be tested though!

From #147 (comment): to start, I think the test file should make sure there are no more instances of JoshuaKGoldberg in the repository at all. Doing so would make sure there are no files being missed by the setup script's find-and-replace.

Additional Info

I'm imagining you can probably use a quick shell script to search in files. Or an npm package. Either way 馃し
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! area: testing Improving how the repository's tests are run and/or code is tested labels Dec 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title 馃洜 Tooling: Make sure no file in the repo contains "josh" in end-to-end setup test 馃洜 Tooling: Make sure no file in the repo contains "josh" or "template-typescript-node-package" in end-to-end setup test Jan 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 9, 2023
@JoshuaKGoldberg JoshuaKGoldberg removed the good first issue Good for newcomers, please hop on! label Mar 9, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: testing Improving how the repository's tests are run and/or code is tested area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg