Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(eslint): ♻️ add eslint-plugin-n to eslint configuration #528

Merged
merged 8 commits into from Jun 15, 2023
Merged

refactor(eslint): ♻️ add eslint-plugin-n to eslint configuration #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68c326a
refactor(eslint): ♻️ add eslint-plugin-n to eslint configuration
navin-moorthy Jun 13, 2023
4920c59
refactor(pnpm): ♻️ run pnpm dedupe
navin-moorthy Jun 13, 2023
59c2a67
chore(eslint): 🧹 add rule to disallow missing import for "template-ty…
navin-moorthy Jun 14, 2023
c9a1250
Merge branch 'main' into eslint-plugin-n
navin-moorthy Jun 14, 2023
0c2af45
Merge branch 'main' into eslint-plugin-n
navin-moorthy Jun 15, 2023
cfabb68
refactor(eslint): ♻️ add eslint-plugin-n without other autofix changes
navin-moorthy Jun 15, 2023
8201061
Merge branch 'main' into eslint-plugin-n
JoshuaKGoldberg Jun 15, 2023
6579167
Hydration too
JoshuaKGoldberg Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .eslintrc.cjs
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ module.exports = {
extends: [
"eslint:recommended",
"plugin:eslint-comments/recommended",
"plugin:n/recommended",
"plugin:perfectionist/recommended-natural",
"plugin:regexp/recommended",
"prettier",
Expand Down Expand Up @@ -126,6 +127,12 @@ module.exports = {
// These off/less-strict-by-default rules work well for this repo and we like them on.
"@typescript-eslint/no-unused-vars": ["error", { caughtErrors: "all" }],
"import/extensions": ["error", "ignorePackages"],
"n/no-missing-import": [
"error",
{
allowModules: ["template-typescript-node-package"],
},
],
JoshuaKGoldberg marked this conversation as resolved.
Show resolved Hide resolved
"no-only-tests/no-only-tests": "error",

// These on-by-default rules don't work well for this repo and we like them off.
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -67,6 +67,7 @@
"eslint-plugin-jsdoc": "^46.0.0",
"eslint-plugin-jsonc": "^2.8.0",
"eslint-plugin-markdown": "^3.0.0",
"eslint-plugin-n": "^16.0.0",
"eslint-plugin-no-only-tests": "^3.1.0",
"eslint-plugin-perfectionist": "^1.1.2",
"eslint-plugin-regexp": "^1.15.0",
Expand Down
43 changes: 37 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions src/hydrate/steps/writing/creation/rootFiles.ts
View file
Open in desktop
Expand Up @@ -46,6 +46,7 @@ module.exports = {
extends: [
"eslint:recommended",
"plugin:eslint-comments/recommended",
"plugin:n/recommended",
"plugin:perfectionist/recommended-natural",
"plugin:regexp/recommended",
"prettier",
Expand Down Expand Up @@ -148,9 +149,13 @@ module.exports = {
rules: {
// These off/less-strict-by-default rules work well for this repo and we like them on.
"@typescript-eslint/no-unused-vars": ["error", { caughtErrors: "all" }],
"import/extensions": ["error", "ignorePackages"],${
values.unitTests ? `\n"no-only-tests/no-only-tests": "error",` : ""
}
"import/extensions": ["error", "ignorePackages"],
"n/no-missing-import": [
"error",
{
allowModules: ["template-typescript-node-package"],
},
],${values.unitTests ? `\n"no-only-tests/no-only-tests": "error",` : ""}

// These on-by-default rules don't work well for this repo and we like them off.
"no-case-declarations": "off",
Expand Down
3 changes: 2 additions & 1 deletion src/shared/getOctokit.ts
View file
Open in desktop
Expand Up @@ -25,7 +25,8 @@ export async function getOctokit(
console.error();
console.error(chalk.red((error as Error).message));
console.error();
process.exit(0);
// eslint-disable-next-line n/no-process-exit
JoshuaKGoldberg marked this conversation as resolved.
Show resolved Hide resolved
process.exit(1);
}

const auth = (await $`gh auth token`).stdout.trim();
Expand Down
5 changes: 3 additions & 2 deletions src/shared/prompts.ts
View file
Open in desktop
@@ -1,8 +1,9 @@
import * as prompts from "@clack/prompts";

export function handleCancel(): never {
export function handleCancel() {
prompts.cancel("Operation cancelled. Exiting - maybe another time? 👋");
process.exit(0);
// eslint-disable-next-line n/no-process-exit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems process.exit(1) is important to terminate the CLI from this point onwards. So added eslint disable next line.

process.exit(1);
}

export function handlePromptCancel(
Expand Down