Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArrayPartition from RecursiveArrayTools.jl #111

Closed
JoshuaLampert opened this issue May 22, 2024 · 0 comments · Fixed by #118
Closed

Use ArrayPartition from RecursiveArrayTools.jl #111

JoshuaLampert opened this issue May 22, 2024 · 0 comments · Fixed by #118

Comments

@JoshuaLampert
Copy link
Owner

JoshuaLampert commented May 22, 2024 •
edited
Loading

Instead of using a single vector where the unknowns of the ode are not stored contiguously in the memory, it would be better to use an ArrayPartition from RecursiveArrayTools.jl. Then we could get rid of wrap_array and some temporary vectors in the semidiscretizations. See also #108 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ArrayPartition from RecursiveArrayTools.jl JoshuaLampert/DispersiveShallowWater.jl
1 participant
@JoshuaLampert