Skip to content

Commit

Permalink
removed unused backup.filename property
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshuaWise committed Jan 17, 2019
1 parent 91531b7 commit b66aefc
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 24 deletions.
18 changes: 8 additions & 10 deletions src/better_sqlite3.cpp
Expand Up @@ -1237,17 +1237,15 @@ void Backup::JS_new (v8::FunctionCallbackInfo <v8 :: Value> const & info)
return;
}

v8 :: Local < v8 :: Context > ctx = isolate -> GetCurrentContext ( ) ;
Backup* backup = new Backup(db, dest_handle, backup_handle, unlink);
backup->Wrap(info.This());
SetFrozen(isolate, ctx, info.This(), CS::filename, destFile);
SetFrozen(isolate, ctx, info.This(), CS::database, database);
SetFrozen(isolate, isolate -> GetCurrentContext ( ) , info.This(), CS::database, database);

info.GetReturnValue().Set(info.This());
}
#line 109 "./src/objects/backup.lzz"
#line 107 "./src/objects/backup.lzz"
void Backup::JS_transfer (v8::FunctionCallbackInfo <v8 :: Value> const & info)
#line 109 "./src/objects/backup.lzz"
#line 107 "./src/objects/backup.lzz"
{
Backup* backup = node :: ObjectWrap :: Unwrap <Backup>(info.This());
if ( info . Length ( ) <= ( 0 ) || ! info [ 0 ] -> IsInt32 ( ) ) return ThrowTypeError ( "Expected " "first" " argument to be " "a 32-bit signed integer" ) ; int pages = v8 :: Local < v8 :: Int32 > :: Cast ( info [ 0 ] ) -> Value ( ) ;
Expand All @@ -1271,21 +1269,21 @@ void Backup::JS_transfer (v8::FunctionCallbackInfo <v8 :: Value> const & info)
Database::ThrowSqliteError(sqlite3_errstr(status), status);
}
}
#line 133 "./src/objects/backup.lzz"
#line 131 "./src/objects/backup.lzz"
void Backup::JS_close (v8::FunctionCallbackInfo <v8 :: Value> const & info)
#line 133 "./src/objects/backup.lzz"
#line 131 "./src/objects/backup.lzz"
{
Backup* backup = node :: ObjectWrap :: Unwrap <Backup>(info.This());
assert(backup->db->GetState()->busy == false);
if (backup->alive) backup->db->RemoveBackup(backup);
backup->CloseHandles();
info.GetReturnValue().Set(info.This());
}
#line 141 "./src/objects/backup.lzz"
#line 139 "./src/objects/backup.lzz"
v8::Persistent <v8::Function> Backup::constructor;
#line 142 "./src/objects/backup.lzz"
#line 140 "./src/objects/backup.lzz"
sqlite3_uint64 Backup::next_id;
#line 143 "./src/objects/backup.lzz"
#line 141 "./src/objects/backup.lzz"
bool Backup::constructing_privileges;
#line 4 "./src/util/custom-function.lzz"
CustomFunction::CustomFunction (v8::Isolate * _isolate, Database * _db, v8::Local <v8::Function> _fn, char const * _name, bool _safe_ints)
Expand Down
22 changes: 11 additions & 11 deletions src/better_sqlite3.hpp
Expand Up @@ -513,27 +513,27 @@ class Backup : public node::ObjectWrap
static void Init (v8::Isolate * isolate, v8::Local <v8 :: Object> exports, v8::Local <v8 :: Object> module);
#line 66 "./src/objects/backup.lzz"
static void JS_new (v8::FunctionCallbackInfo <v8 :: Value> const & info);
#line 109 "./src/objects/backup.lzz"
#line 107 "./src/objects/backup.lzz"
static void JS_transfer (v8::FunctionCallbackInfo <v8 :: Value> const & info);
#line 133 "./src/objects/backup.lzz"
#line 131 "./src/objects/backup.lzz"
static void JS_close (v8::FunctionCallbackInfo <v8 :: Value> const & info);
#line 141 "./src/objects/backup.lzz"
#line 139 "./src/objects/backup.lzz"
static v8::Persistent <v8::Function> constructor;
#line 142 "./src/objects/backup.lzz"
#line 140 "./src/objects/backup.lzz"
static sqlite3_uint64 next_id;
#line 143 "./src/objects/backup.lzz"
#line 141 "./src/objects/backup.lzz"
static bool constructing_privileges;
#line 145 "./src/objects/backup.lzz"
#line 143 "./src/objects/backup.lzz"
Database * const db;
#line 146 "./src/objects/backup.lzz"
#line 144 "./src/objects/backup.lzz"
sqlite3 * const dest_handle;
#line 147 "./src/objects/backup.lzz"
#line 145 "./src/objects/backup.lzz"
sqlite3_backup * const backup_handle;
#line 148 "./src/objects/backup.lzz"
#line 146 "./src/objects/backup.lzz"
sqlite3_uint64 const id;
#line 149 "./src/objects/backup.lzz"
#line 147 "./src/objects/backup.lzz"
bool alive;
#line 150 "./src/objects/backup.lzz"
#line 148 "./src/objects/backup.lzz"
bool unlink;
};
#line 1 "./src/util/custom-function.lzz"
Expand Down
4 changes: 1 addition & 3 deletions src/objects/backup.lzz
Expand Up @@ -97,11 +97,9 @@ private:
return;
}

UseContext;
Backup* backup = new Backup(db, dest_handle, backup_handle, unlink);
backup->Wrap(info.This());
SetFrozen(isolate, ctx, info.This(), CS::filename, destFile);
SetFrozen(isolate, ctx, info.This(), CS::database, database);
SetFrozen(isolate, OnlyContext, info.This(), CS::database, database);

info.GetReturnValue().Set(info.This());
}
Expand Down

0 comments on commit b66aefc

Please sign in to comment.