Refactor to make the package installable via PyPI #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small refactor has been performed to include the setup.py. Dependencies are now managed by this file, as well as package versioning and so on. Internal imports are now imported using `metafinder.utils.<whatever>` syntax. For clarity, the launcher (`cli.py`) has been separated from the `processing(...)` method. This approach is closer to the use of the package as a library making it closer to be imported as `import metafinder.core`. Some minor issues have also been addressed: - The number of the results returned by Google was always 1 less - A new argument has been provided to set the output folder - The `results` folder is now created if it does not exist - `pathlib` package has been used for the creation of the folder - The usage execution has been clarified - Versioning has been started as `0.1.0`. This may be changed. Installation instructions in the `README.md` have been updated. Note that these instructions won't be ready until the package is uploaded to PyPI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactor has been performed to include the setup.py.
Dependencies are now managed by this file, as well as package
versioning and so on. Internal imports are now imported using
metafinder.utils.<whatever>syntax. For clarity, the launcher(
cli.py) has been separated from theprocessing(...)method.This approach is closer to the use of the package as a library
making it closer to be imported as
import metafinder.core.Some minor issues have also been addressed:
resultsfolder is now created if it does not existpathlibpackage has been used for the creation of the folder0.1.0. This may be changed.Installation instructions in the
README.mdhave been updated.Note that these instructions won't be ready until the package
is uploaded to PyPI.