Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bluetooth Library #13

Closed
askpatrickw opened this issue May 15, 2020 · 3 comments
Closed

Add Bluetooth Library #13

askpatrickw opened this issue May 15, 2020 · 3 comments

Comments

@askpatrickw
Copy link

Is there any concern with adding bluetooth\ubluetooth to createstubs?

I'm happy to submit a PR, but I wanted to check that all is needed is to add it to the hardcoded list starting around line 80.

This would be my PR
askpatrickw@7fba58e#diff-f980488c64e09b41b963829d88a15d94

@Josverl
Copy link
Owner

Josverl commented Jul 25, 2020

Hi Patrick ,
sorry for the tardiness
yes that is one of the ways that should allow the stubs to be generated for the bluetooth module.
another way is to uncomment & change one line in the script

    # stubber.add_modules(['xyz'])  TO 
   stubber.add_modules(['bluetooth'])

for which firmware are you generating ?
if it is a common firmware i'm happy to merge your PR

@askpatrickw
Copy link
Author

Hi @Josverl sorry long in getting back to you, this was on MicroPython on a TinyPico (If I remember correctly) not a fork.

@Josverl
Copy link
Owner

Josverl commented Oct 18, 2020

Hi Patrick ,
I have updated the code and createstubs.py version 1.3.4 includes the stubbing of the Bluetooth module if it is included in the firmware.

i've ran the stubber on a nightly of the 1.13 build and you can pick up the bluetooth stub module on the micropython-stubs repo

Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants