Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractVerticle#stop / AbstractVerticle#start not executed via async #1

Open
Jotschi opened this issue Nov 5, 2021 · 0 comments
Open

Comments

@Jotschi
Copy link
Owner

Jotschi commented Nov 5, 2021

The AbstractVerticle#stop / AbstractVerticle#start methods are currently not being wrapped via Async#async.

The DeploymentManager invokes the methods using the context of the verticle (via runOnContext).

The context is provided via vertx.createWorkerContext / vertx.createEventLoopContext.

Options:

  • Patch createWorkerContext / createEventLoopContext methods in Vert.x (e.g. by providing a custom thread factory.)
  • Patch DeploymentManager to wrap the start / stop calls with Async.async
  • Leave the behaviour unchanged. Thus it would be required for a user to manually use Async.async within the start method implementation of the custom verticle.
  • Patch ContextImpl#runOnContext to use Async.async.
  • Add startAsync / stopAsync abstract methods to io.vertx.loom.core.AbstractVerticle and invoke those from regular start / stop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant