Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(rollup/webpack) - Add isReactComponent check in isComponent #238

Merged
merged 5 commits into from
Dec 11, 2020
Merged

(rollup/webpack) - Add isReactComponent check in isComponent #238

merged 5 commits into from
Dec 11, 2020

Conversation

sidujjain
Copy link
Contributor

No description provided.

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests failing is due to having to add

  "resolutions": {
    "@prefresh/utils": "file:../../packages/utils"
  },

In both nollup and webpack. Would you mind running yarn changeset as well to indicate the minor for these packages

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2020

🦋 Changeset detected

Latest commit: 5b798ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@prefresh/nollup Minor
@prefresh/utils Minor
@prefresh/webpack Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock changed the title Add isReactComponent check in isComponent (rollup/webpack) - Add isReactComponent check in isComponent Dec 11, 2020
@JoviDeCroock
Copy link
Member

Oh, sorry forgot to mention, you'll need to add the resolution to next as well

sidujjain and others added 2 commits December 12, 2020 02:18
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much

@JoviDeCroock JoviDeCroock merged commit 39bcf44 into preactjs:main Dec 11, 2020
@github-actions github-actions bot mentioned this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants