-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(rollup/webpack) - Add isReactComponent check in isComponent #238
(rollup/webpack) - Add isReactComponent check in isComponent #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests failing is due to having to add
"resolutions": {
"@prefresh/utils": "file:../../packages/utils"
},
In both nollup and webpack. Would you mind running yarn changeset
as well to indicate the minor for these packages
🦋 Changeset detectedLatest commit: 5b798ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Oh, sorry forgot to mention, you'll need to add the resolution to next as well |
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much
No description provided.