Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari Footer Bug #327

Closed
itopaloglu83 opened this issue Jul 22, 2023 · 3 comments
Closed

Safari Footer Bug #327

itopaloglu83 opened this issue Jul 22, 2023 · 3 comments

Comments

@itopaloglu83
Copy link

Hello,

It seems like there is a bug related to how the footer element is rendered in Safari. It is somehow pushed down 20px forcing the Safari to always show a scrollbar. You can see the issue just by opening the app with Safari, no further steps are needed.

From what I can surmise, it's caused by two child components of the main overflowing 20px top and bottom. I experimented with my limited CSS knowledge and updating the style.scss seems to resolve the issue while keeping Chrome happy.

main {
  margin-top: 20px;
  margin-bottom: 20px;
  min-height: calc(100% - 156px);
}

I was going to create a pull request but wanted to start a discussion about it first in case I missed something.

@Joxit
Copy link
Owner

Joxit commented Jul 22, 2023

Hi, thank you for using my project and submitting issues 😊

Can you post one screenshot for the posterity?

@itopaloglu83
Copy link
Author

Thank you for the project!

Before:

main {
  min-height: calc(100% - 136px);
}
Screenshot 2023-07-22 at 22 52 50

After:

main {
  margin-top: 20px;
  margin-bottom: 20px;
  min-height: calc(100% - 156px);
}
Screenshot 2023-07-22 at 22 55 52

@Joxit Joxit closed this as completed in f015187 Jul 23, 2023
@Joxit
Copy link
Owner

Joxit commented Jul 23, 2023

Thank you for the details, this should be fixed in v2.5.2

I used flex instead of this old min-height to also support screens with small width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants