Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to add NFTs to existing featured NFTs #4161

Open
drillprop opened this issue May 9, 2023 · 2 comments
Open

Make possible to add NFTs to existing featured NFTs #4161

drillprop opened this issue May 9, 2023 · 2 comments
Assignees
Labels

Comments

@drillprop
Copy link
Contributor

Context
Currently, an operator can only set an array of ids, and once he set them, all the previously featured NFTs will be overwritten. For example, if an operator runs:

mutation {
    setFeaturedNfts(featuredNftsIds: ["1", "2"]) {
        newNumberOfNftsFeatured
    }
}

and then let's say he wants to add more NFTs to the existing set, If he runs:

mutation {
    setFeaturedNfts(featuredNftsIds: ["3", "4"]) {
        newNumberOfNftsFeatured
    }
}

The featured NFTs will be only “3” and “4”.

To fix this he needs to provide all the ids, so in the case above, he would have to write this mutation:

mutation {
    setFeaturedNfts(featuredNftsIds: ["1", "2", "3", "4"]) {
        newNumberOfNftsFeatured
    }
}

Solution
Introduce:

  • addFeaturedNfts mutation
  • removeFeaturedNfts mutation
@dmtrjsg
Copy link

dmtrjsg commented Oct 16, 2023

@ignazio-bovo assigned to you to get this merged (was reviewed already but at this point there likely be conflicts that require resolution).

This is lower prio compared to Notifications and change requests for CRTs.

@dmtrjsg
Copy link

dmtrjsg commented Jun 6, 2024

we don't need to do it, but since its done then better to merge :)

@dmtrjsg dmtrjsg reopened this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants