Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify: no new proposals in runtime #3891

Closed
bedeho opened this issue Jun 13, 2022 · 2 comments
Closed

Verify: no new proposals in runtime #3891

bedeho opened this issue Jun 13, 2022 · 2 comments
Assignees
Labels

Comments

@bedeho
Copy link
Member

bedeho commented Jun 13, 2022

Last check for Carthage.

┆Issue is synchronized with this Asana task by Unito

@Lezek123
Copy link
Contributor

Lezek123 commented Sep 5, 2022

Current state (as of 3f946c4):

  • The only new proposals vs master are:
    • UpdateGlobalNftLimitProposal
    • UpdateChannelPayoutsProposal
  • Proposals that were removed:
    • CreateBlogPostProposal
    • EditBlogPostProoposal
    • LockBlogPostProposal
    • UnlockBlogPostProposal

This is the expected state, to be confirmed just before launching carthage

@Lezek123
Copy link
Contributor

Lezek123 commented Nov 7, 2022

State unchanged since last comment (w.r.t. new proposals introduced)

There are some proposal validation changes worth noting however:

  • MAX_SPENDING_PROPOSAL_VALUE => FundingRequestProposalMaxTotalAmount, besides the fact that the constant is now exported, the validation logic is now different: this is no longer a max value per account, but per entire proposal (which may include many accounts to fund)
  • FillWorkingGroupLeadOpening: opening id and application id is now validated during proposal creation
  • DecreaseWorkingGroupLeadStake: leader worker id is now validated during proposal creation
  • SlashWorkingGroupLead: leader worker id is now validated during proposal creation
  • SetWorkingGroupLeadReward: leader worker id is now validated during proposal creation
  • TerminateWorkingGroupLead: leader worker id is now validated during proposal creation
  • CancelWorkingGroupLeadOpening: opening id is now validated during proposal creation
  • VetoProposal - proposal id is now validated during proposal creation

Additionally:

  • the new UpdateGlobalNftLimitProposal creation is disabled via filter_stage_2

@Lezek123 Lezek123 closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants