Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download timeouts - use deadline in addition to response timeout #5053

Open
mnaamani opened this issue Jan 19, 2024 · 0 comments
Open

Download timeouts - use deadline in addition to response timeout #5053

mnaamani opened this issue Jan 19, 2024 · 0 comments
Labels
argus Argus distributor node colossus

Comments

@mnaamani
Copy link
Contributor

We use superagent package to fetch assets from remote nodes.
Currently we pass a single timeout value when we consider the download failed, or want to stop processing a task.
This timeout is the "deadline" timeout, but we should also use the "response" timeout to more quickly determine a download is going to be slow and move to download from the next source.

See: https://github.com/ladjs/superagent/blob/master/docs/index.md#timeouts

@mnaamani mnaamani added colossus argus Argus distributor node labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argus Argus distributor node colossus
Projects
Development

No branches or pull requests

1 participant