Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archived <CategoryListItem /> shouldn't query Moderators #1260

Closed
thesan opened this issue Aug 24, 2021 · 3 comments
Closed

Archived <CategoryListItem /> shouldn't query Moderators #1260

thesan opened this issue Aug 24, 2021 · 3 comments
Labels
carthage Carthagne Network enhancement New feature or request qa-task qa-tested-ready-for-prod scope:forum The "Forum" page and related features

Comments

@thesan
Copy link
Member

thesan commented Aug 24, 2021

Loading the categories is already a bit slow, so since the archived CategoryListItem don't show the moderators it would be better not to query these categories moderators data.

┆Issue is synchronized with this Asana task by Unito

@thesan thesan added enhancement New feature or request scope:forum The "Forum" page and related features labels Aug 24, 2021
@jodator jodator added the good first issue These issues are a great way to get started with a Pioneer label Sep 28, 2021
@oleksanderkorn
Copy link
Contributor

oleksanderkorn commented Nov 8, 2021

@jodator
As I can see moderators are included in useGetForumCategoriesQuery query:

moderators: Array<{
      __typename: 'Worker'
      id: string
      membership: { __typename: 'Membership'; id: string; handle: string }
    }>

So the way to fix is to create and use another query in ForumArchived that does not fetch moderators, do you agree with that approach?

@jodator
Copy link
Contributor

jodator commented Nov 8, 2021

So the way to fix is to create and use another query in ForumArchived that does not fetch moderators, do you agree with that approach?

I think that this might be a good approach. Just be sure that you follow the query-node guide. The change should originate from council.graphql file.

@traumschule traumschule added qa-task carthage Carthagne Network and removed good first issue These issues are a great way to get started with a Pioneer labels Oct 23, 2022
@ivanturlakov
Copy link

✅ Tested on https://dao-git-carthage-joystream.vercel.app/#/forum
wss://44.201.112.198.nip.io/ws-rpc

@traumschule @oleksanderkorn Let me know if there is a specific scenario I need to test

2022-11-02.13.15.38.mov

@dmtrjsg dmtrjsg moved this from Ready to Test to Tested - Ready for Prod in Pioneer Community Product Development Nov 4, 2022
@dmtrjsg dmtrjsg closed this as completed Dec 9, 2022
Pioneer Community Product Development automation moved this from Tested - Ready for Prod to Closed - On Prod Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carthage Carthagne Network enhancement New feature or request qa-task qa-tested-ready-for-prod scope:forum The "Forum" page and related features
Projects
Development

No branches or pull requests

6 participants