Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notifications: signer modal component and transaction #4232

Closed
4 tasks
Tracked by #4230
dmtrjsg opened this issue Mar 14, 2023 · 9 comments
Closed
4 tasks
Tracked by #4230

Email notifications: signer modal component and transaction #4232

dmtrjsg opened this issue Mar 14, 2023 · 9 comments
Labels
community-dev issue suitable for community-dev pipeline release:2.0.0 scope:notifications Notifications subsystem

Comments

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Mar 14, 2023

Context

Backend

⚠️ Link to BE API implementation >

Dependencies

Blocks:

Blocked by:

Scope

  • Create component (Signer modal for connecting tx email with membership.) Link to Design >
    -- email input
    -- membership controller account displayed which is used to sign
    -- Ctas: "sign and authorize email"; "Not now"
    -- state when email is not provided -> CTA "sign and authorise" is disabled unless email is provided
  • When email is provided and modal signed, confirmation email must be sent..
  • Confirmation email template for email auth. HTML template is required to be used see
  • [backend] Write nicer html emails #4274 point 1.
  • Following the link user is brought back to the App with confirmation modal shown. Link to design>

Design

Links are added to acceptance criteria
Preview:
Screenshot 2023-03-30 at 18 08 42

@dmtrjsg dmtrjsg changed the title Manage notifications: unsubscribe Email notifications: signer modal component and transaction Mar 14, 2023
@dmtrjsg dmtrjsg added the scope:notifications Notifications subsystem label Mar 14, 2023
@dmtrjsg dmtrjsg added the community-dev issue suitable for community-dev pipeline label Mar 30, 2023
@IlyaSmiyukha
Copy link
Contributor

I have a few questions about styling the modal.

  1. I didn't find text for the tooltip in label
  2. Can I remove the such a big gap between footer and blue alert?
  3. I see background-color: #E8EDF6; for footer in figma, but default color is #fff for all modals. Should I change it?

@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented Apr 4, 2023

@IlyaSmiyukha
Thanks for the questions.

  1. Tooltip text: Add your email address here to receive notifications. It can be the same or different to the one added to the membership profile.
  2. Let's keep the modal dimensions as this component is standardized.
  3. Feel free to use the default colour for the modal footers.

@IlyaSmiyukha
Copy link
Contributor

@dmtrjsg Got it. Thanks for the quick response

@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented Apr 6, 2023

@IlyaSmiyukha have you managed to run the backend to be able to test this?

@IlyaSmiyukha
Copy link
Contributor

@dmtrjsg No, I got this error. But .env I copied from .env.dev
Screenshot 2023-04-08 at 14 31 46

@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented Apr 8, 2023

@IlyaSmiyukha ok thx for letting us know i'll try to resolve asap. Monday is a day off for most of our team so perhaps this would need to wait till Tuesday morning.

@thesan
Copy link
Member

thesan commented Apr 8, 2023

@dmtrjsg No, I got this error. But .env I copied from .env.dev
Screenshot 2023-04-08 at 14 31 46

@IlyaSmiyukha this means that you shouldn't define both the sendgrid and the mailgun config. But for the purpose of this issue, you don't need to define an email provider. So all the variables in the Email (only one of the api provider should be defined) section should be removed or commented from your .env file.

@IlyaSmiyukha
Copy link
Contributor

@thesan it helped, thanks

@thesan
Copy link
Member

thesan commented Apr 9, 2023

@IlyaSmiyukha np !

I just fixed issues with the sign-up/sign-in mutations on the branch of this PR: #4337. So you should run the backend from this branch to implement this modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline release:2.0.0 scope:notifications Notifications subsystem
Projects
Development

Successfully merging a pull request may close this issue.

4 participants