Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show script ran successful message #35

Closed
singla-shivam opened this issue Jul 3, 2022 · 0 comments · Fixed by #36
Closed

Feature: show script ran successful message #35

singla-shivam opened this issue Jul 3, 2022 · 0 comments · Fixed by #36

Comments

@singla-shivam
Copy link
Member

As mentioned in the docs, console.assert prints the error to stderr, but it does not throw an error. It means the script still exits with exit code 0 (if everything goes well).

#33 (comment)

Showing "Assertion error" and also showing "Example ran successfully" makes no sense. So, we should remove "Example ran successfully" message from the examples in Fae. It will result in cleaner example scripts in Fae and more reliable failing chec in Fae.

But in the playground, it will not be apparent when the script ran successfully because there will no output in case of examples. Not only in case of examples, some developer will write a code for type check in the playground, or use console.assert in their script. So it is more advisable to show successful notification/popup in the playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant