Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with sample using docker-compose version '3' #226

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Update readme with sample using docker-compose version '3' #226

merged 1 commit into from
Jun 30, 2017

Conversation

evertramos
Copy link
Contributor

Hi there!

Thanks for the good work and I would like to share a new sample.

Cheers!

@JrCs JrCs merged commit d777195 into nginx-proxy:master Jun 30, 2017
@buchdag
Copy link
Member

buchdag commented Jun 30, 2017

@evertramos your docker-compose configuration won't reload nginx on automated certificate renewal and serve the renewed certificates due to the absence of the NGINX_PROXY_CONTAINER environment variable.

See the last bullet point there and the relevant PR.

@evertramos
Copy link
Contributor Author

Thanks for the comment @buchdag,

I have the option in the jrcs/docker-letsencrypt-nginx-proxy-companion container, as of:

environment:
      NGINX_DOCKER_GEN_CONTAINER: "nginx-gen"

Isn´t that right? Or I must have specify it somewhere else?

@buchdag
Copy link
Member

buchdag commented Jun 30, 2017

If you use a docker-compose version 3 file with the three container setup (nginx / docker-gen / letsencrypt) you actually have to specify both environment variable on the letsencrypt container:

NGINX_PROXY_CONTAINER pointing to the nginx container itself
NGINX_DOCKER_GEN_CONTAINER pointing to the docker-gen container as you did

@evertramos
Copy link
Contributor Author

evertramos commented Jun 30, 2017

@buchdag

So it would be like this:

nginx-letsencrypt:
[...]
environment:
      NGINX_DOCKER_GEN_CONTAINER: "nginx-gen"
      NGINX_PROXY_CONTAINER: "nginx"

Is that it?

Thank you very much for your attention on that! It would take me 90 days to realize it.

evertramos added a commit to evertramos/nginx-proxy-automation that referenced this pull request Jun 30, 2017
@buchdag
Copy link
Member

buchdag commented Jun 30, 2017

Yep, that's it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants