Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time constant should not be overridden #2

Open
grepsedawk opened this issue Jun 15, 2022 · 1 comment
Open

Time constant should not be overridden #2

grepsedawk opened this issue Jun 15, 2022 · 1 comment

Comments

@grepsedawk
Copy link
Contributor

On line https://github.com/wagyourtail/JsMacros-Ruby/blob/main/src/main/java/xyz/wagyourtail/jsmacrosjruby/ruby/language/impl/RubyLanguageDefinition.java#L47 , the ruby class Time is getting overriden to https://jsmacros.wagyourtail.xyz/?/1.7.0/xyz/wagyourtail/jsmacros/client/api/library/impl/FTime.html which makes doing "normal ruby time things" difficult.

Instead, the script should just skip the Time constant (as those things can be done in jruby directly, anyway)
@grepsedawk
Copy link
Contributor Author

[12:55 PM] Wagyourtail: 🤔 rename the class I'm pushing as time to FTime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grepsedawk