Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @import from CSS #13

Open
EduFdezSoy opened this issue Feb 25, 2018 · 5 comments
Open

Remove @import from CSS #13

EduFdezSoy opened this issue Feb 25, 2018 · 5 comments

Comments

@EduFdezSoy
Copy link
Contributor

EduFdezSoy commented Feb 25, 2018

The @import function from CSS make the files load sequentially, it is recomended to avoid it. I sugest to remove it and write in the docs what fonts Cake recomends to import in HTML with <link>.

@EduFdezSoy EduFdezSoy changed the title Sacar @import del CSS Remove @import from CSS Feb 25, 2018
@JuanjoSalvador
Copy link
Owner

Could it be a problem?

@EduFdezSoy
Copy link
Contributor Author

Well, on a small project it wont be. But on larger projects or in slow networks change it could improve the load speed.

@JuanjoSalvador
Copy link
Owner

On hold then.

@mannski
Copy link

mannski commented Oct 25, 2018

I looked into this, and I don't think it will be possible. Cake allows users to import the CSS in one line:
<link rel="stylesheet" type="text/css" href="/path/to/cake/cake.min.css">

If we remove the @imports, the user will have to add link tags for the Google Fonts as well, which is not ideal.

Suggested solution: replace Google fonts with standard web-safe fonts so that the imports are no longer necessary. Otherwise, leave the imports.

@JuanjoSalvador
Copy link
Owner

The @imports for Google fonts is "necesary". I mean, it's fine if we have them, and it will be fine without them, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants