Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text of uilabel does not change when it is in showAnimatedSkeleton. #330

Closed
7 tasks
greatsk55 opened this issue Sep 17, 2020 · 2 comments
Closed
7 tasks

Comments

@greatsk55
Copy link

greatsk55 commented Sep 17, 2020

Description

The text of uilabel does not change when it is in showAnimatedSkeleton.
i'm using storyboard.

ex )

vc view----------
| baba(label)
|
|
|
|------------------

view.showAnimatedSkeleton(usingColor: .clouds, animation: .none, transition: .none)
label.text = "haha"
view.hideSkeleton()

label text is still baba.

What type of issue is this? (place an x in one of the [ ])

  • [ X ] bug
  • enhancement (feature request)
  • question
  • documentation related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version:
Xcode version:
Swift version:

Steps to reproduce:

Please replace this with the steps to reproduce the behavior.

Expected result:

Please replace this with what you expected to happen.

Actual result:

Please replace this with of what happened instead.

Attachments:

Logs, screenshots, sample project, funny gif, etc.

@Juanpe
Copy link
Owner

Juanpe commented Oct 2, 2020

Hi @greatsk55 , the next version will fix this problem.

If you want to check if the problem is solved with this fix you can set the dependency in your podfile, pointing to the develop branch.

Podfile
pod 'SkeletonView', :git => 'https://github.com/Juanpe/SkeletonView.git', :branch => 'develop'

@Juanpe
Copy link
Owner

Juanpe commented Oct 2, 2020

SkeletonView v1.10 has been released, so you don't need to modify your podfile :)

@Juanpe Juanpe closed this as completed Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants