Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Structure #1

Merged
merged 4 commits into from Mar 22, 2022
Merged

List Structure #1

merged 4 commits into from Mar 22, 2022

Conversation

Juanse7793
Copy link
Owner

Here I add:

  • All Webpack setup
  • index.html in the src folder
  • style.css in the src folder
  • index.js in the src folder

Requirements

  • I Set up a new project with webpack that is based on the webpack exercise that I have already completed.
  • I Create an index.html file and wrote my HTML markup there. I Create an empty To-Do List placeholder. The
    index.html file is set as a template using the HTML Webpack Plugin.
  • I Create an index.js file and set an array of some simple to-do tasks (array of objects). Each task object contains three keys:
    • description [string].
    • check [bool].
    • index: [number].
  • I Wrote a function to iterate over the tasks array and populate an HTML list item element for each task.
  • On page load, I render the dynamically created list of tasks in the dedicated placeholder. The list is appearing in order of the index values for each task.
  • I Create a style.css and set rules for the To-Do List. CSS is loaded by Webpack Style/CSS Loader. My list is a clone of the part of the minimalist project captured in the video shown in the lesson.
  • All my source files (index.html, index.js, and style.css) are be located in the /src directory and your distribution files are generated by webpack and served by the webpack dev server from the /dist folder.

Copy link

@GzimAsani GzimAsani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 💯

Thank you for implementing all the project requirements, you've done a great job. 🏆 There is nothing else to say other than... it's time to merge it 🍾 🎉 Congratulations

Cheers and Happy coding! 👏 💻 🍷
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Juanse7793 Juanse7793 merged commit 86ffdbf into main Mar 22, 2022
@Juanse7793 Juanse7793 deleted the feature branch March 22, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants