-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array notifications are applied wrong after inserting and removing a row #5
Comments
@tomalec could you please take a look? |
Shorted test case:
|
It is index |
It seems we are facing all the problems that are solved by Polymer's @warpech, @miyconst WDYT about forking (and making a PR of)
For me injecting one more template to the dom-repeat seems easier that replicating its behavior. Also to replicate dom-repeat logic, we would need to go through and understand entire code anyway. |
Or maybe we should just ask people to fallback to:
na make juicy-element do nothing more than just extending |
<juicy-table>
<template is="dom-repeat">
</template>
</juicy-table> If it works, I'd love it! |
@tomalec am I right that you want to stamp Well, if that would work, I am all for it. P.S. Any solution which works in IE to generate table rows is good for me, even if it requires a bit more code or another |
I wonder if you can get this to work: <juicy-table class="table"><!-- "table" is a Bootstrap class -->
<thead>
<tr>
<template is="dom-repeat" items="{{Headers}}"><!-- my column headers -->
<th>{{item.Label}}</th>
</template>
</tr>
</thead>
<tbody>
<template is="dom-repeat" items="{{People}}"><!-- my rows -->
<tr><td>{{item.FirstName}}</td><td>{{item.LastName}}</td></tr>
</template>
</tbody>
</juicy-table> See source of Bootstrap |
It works but you loose user agent styles See https://jsbin.com/coxere/edit?html,output
|
@warpech as far as I remember it won't work. IE removes every node from So, it will be equal to: <juicy-table class="table"><!-- "table" is a Bootstrap class -->
<thead>
<tr>
</tr>
</thead>
<template is="dom-repeat" items="{{Headers}}"><!-- my column headers -->
<th>{{item.Label}}</th>
</template>
<tbody>
</tbody>
<template is="dom-repeat" items="{{People}}"><!-- my rows -->
<tr><td>{{item.FirstName}}</td><td>{{item.LastName}}</td></tr>
</template>
</juicy-table> Does not seem to work even in Chrome - https://jsfiddle.net/qc5qv5e5/. |
For that we will need |
@tomalec your solution does not seem to work in IE: |
My bad. So we need to either
|
@warpech how urgently do we need a fix, and how crucial it is? |
I'd love to 😎 Especially, that it seems that event Microsoft is pushing Edge forward and do not bother much about IE11 support. The question is: what about our customers, and demos that are supposed to look clean and work cross platform? |
No, it is not urgent. I just saw it and reported it for reference.
Let's not drop IE11support before Polymer.
|
Polymer only partially supports it. |
Let's wait until Polymer 2.0, which may fix this |
Steps to reproduce:
The last 3 rows are updated with a new price. Only one row (the first row) should be updated.
See:
The text was updated successfully, but these errors were encountered: