Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid dynamic height calculation #17

Closed
miyconst opened this issue Jul 24, 2015 · 4 comments
Closed

Invalid dynamic height calculation #17

miyconst opened this issue Jul 24, 2015 · 4 comments
Assignees

Comments

@miyconst
Copy link

People application, /people/persons/add page.

This is how it looks when email/address/phone is added by button:
image

And this is how it looks when they already exists:
image

cc @tomalec

@tomalec tomalec self-assigned this Jul 27, 2015
@tomalec
Copy link
Member

tomalec commented Jul 27, 2015

For sure you can solve it by setting some initial value for height, like height: 1 for tile that should grow dynamically.

@tomalec
Copy link
Member

tomalec commented Jul 27, 2015

I'm not sure what should be desired solution. As in your setup, you make addresses list tile height to be pre-calculated, what in this case resolves to 0.

So the question is where should we put, and how to layout tile with size 0. (#18).

Currently, I would say, it was put in correct position. After packing all items with higher priority, the first free space to pack 100% x 0 tile is exactly bellow "Addresses". Then as (due to 0 height) it didn't shrink the free space, next tile was packed to the same spot.

@tomalec tomalec mentioned this issue Jul 27, 2015
@tomalec
Copy link
Member

tomalec commented Jul 27, 2015

@miyconst Can we close it, as it occurred to be a result of tile size 0 been packed, and miscalculation of precalculateHeight (as it is done before some content is loaded asynchronously)?

@miyconst
Copy link
Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants