Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #22

Open
HereAround opened this issue Oct 20, 2022 · 2 comments
Open

Increase test coverage #22

HereAround opened this issue Oct 20, 2022 · 2 comments

Comments

@HereAround
Copy link
Member

HereAround commented Oct 20, 2022

  • Some error messages not tested in the new fetch/read polytope methods. (This should be easy, I think.)
  • Also, we never test reading from files. Somehow, this should be tested.

@ariostas Any thoughts on the latter?

@ariostas
Copy link
Member

I'm not very familiar with how GitHub testing works. However, reading from a file vs string uses the same code, so as long as the few lines that read the contents of the file are not broken then it should be fine.

@HereAround
Copy link
Member Author

There are multiple sets of tests being executed:

  1. Running the code,
  2. Executing code that is used for the documentation,
  3. Setting up and deploying (i.e. shipping to the website) the documentation.

Here, I am mostly thinking about 1. Those tests are spelled out in the /test/runtests.jl file. (The doc tests are all examples that you add for the docstrings.) In the case at hand, I would like to check that the few lines that read from a file work. From what I read in the code and you are saying, the file should have the same content as the string that we are currently handing over to the method, correct?

If yes, then we could indeed add this as a test file and use that to add test coverage for those lines too.

Minor related point: Unless I am mistaken, as of now, the code does not test if the exists and is readable. So this might backfire badly. Could be improved as we add tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants