New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement `modes` for `UnivariateFinite` objects #58

Closed

ablaom opened this issue Sep 11, 2023 · 0 comments · Fixed by #59

Labels

good first issue

Member

ablaom commented Sep 11, 2023

Code can follow the pattern already established for mode, which is already implemented:

mode is implemented here:

CategoricalDistributions.jl/src/methods.jl

Line 161 in 4be9db4

function Dist.mode(d::UnivariateFinite)
And efficient broadcasting of mode for UnivariantFiniteArray is implemented here:

CategoricalDistributions.jl/src/arrays.jl

Line 276 in 4be9db4

function Base.Broadcast.broadcasted(::typeof(mode),

The text was updated successfully, but these errors were encountered:

ablaom added the good first issue label

skleinbo mentioned this issue

Implement modes #59

Merged

ablaom closed this as completed in #59

This was referenced Sep 13, 2023

For a 0.1.11 release #61

Merged

Issue to trigger new releases #1

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment