Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload fit_data_scitype trait #16

Closed
ablaom opened this issue Jun 26, 2024 · 1 comment
Closed

Overload fit_data_scitype trait #16

ablaom opened this issue Jun 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ablaom
Copy link
Member

ablaom commented Jun 26, 2024

Since RFE is Unsupervised the fallback for fit_data_scitype is wrong. We need something like:

MMI.fit_data_scitype(::RecursiveFeatureElimination{M}) where M = Union{
    Tuple{input_scitype(M), target_scitype(M)},
    Tuple{input_scitype(M), target_scitype(M), AbstractVector{<:Real},
}

Sorry this is not documented in the MLJModelInterface docs, but I have opened an issue to correct this.

@ablaom ablaom added the bug Something isn't working label Jun 26, 2024
@ablaom ablaom assigned ablaom and OkonSamuel and unassigned ablaom Jun 26, 2024
@ablaom
Copy link
Member Author

ablaom commented Jun 27, 2024

Closing as working on a different resolution.

The problem is that you can't use RFE in a pipeline at the moment.

@ablaom ablaom closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants