-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to know which models are regression models? #191
Comments
There is a trait. It's called You could do this:
Try
A smaller list, because this task has other traits being matched simultaneously. |
I dislike this API. It boils down to that issue #166 of tasks containing information about data. Now, because of this design choice, a model is considered a regression model because it is being applied to continuous data. So if I apply a classifier to data, which happens to be Float64, this classifier will be a regressor? Can we have a trait for the model itself which is independent of the data? |
We already have this information in most model names Issue #166 is really at the core of all my concerns regarding the current design. |
In other words, given a |
I think you misunderstand.
So you don't need tasks to do this, but, in the current design, a task infers this trait from the data it wraps. |
I see, thanks for the clarification. That is perfect. |
BTW. Expect a small change soon to the trait definitions to make them more general (less biased to Tabular data) and conceptually simpler. |
Looking forward to it 👍 |
(you should be able to use scitype to get this information easily, right, @ablaom ?) |
Is your feature request related to a problem? Please describe.
I am interested in asserting that models are compatible with tasks. For example, I have defined a set of learning tasks here, and would like to make sure that for example a
DecisionTreeRegressor
can be used for aRegressionTask
but not aDecisionTreeClassifier
.Describe the solution you'd like
I would like to have a trait for the models that tells whether or not the model is a regressor, a classifier, or a clustering model.
Describe alternatives you've considered
Didn't think of alternatives. Type traits seem like a good solution.
Additional context
I have strategies implemented for applying MLJ models in spatial problems. Being able to distinguish the models according to their nature is essential to a robust implementation.
I am happy to provide a PR if it is welcome.
The text was updated successfully, but these errors were encountered: