Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an abstract type in a struct #15

Closed
ablaom opened this issue Aug 17, 2023 · 0 comments
Closed

Remove an abstract type in a struct #15

ablaom opened this issue Aug 17, 2023 · 0 comments

Comments

@ablaom
Copy link
Member

ablaom commented Aug 17, 2023

MLJFlow.jl/src/types.jl

Line 28 in d36386b

verbosity::Integer

Change verbosity::Integer to verbosity::Int.

Integer is abstract. Generally we avoid abstract types in structs. If we need a generic type we add a type parameter instead (not needed here).
@pebeto pebeto closed this as completed Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pebeto @ablaom