Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params(::MLJType) method #173

Open
ablaom opened this issue Jul 3, 2023 · 1 comment
Open

params(::MLJType) method #173

ablaom opened this issue Jul 3, 2023 · 1 comment

Comments

@ablaom
Copy link
Member

ablaom commented Jul 3, 2023

I would like to remove this method, as it's essentially "wrong", because it is field-based, instead of property-based. It is my understanding that the method does not appear in any documentation but it may appear in some old tutorials. Unfortunately, it is re-exported by MLJBase, and so removing it will break MLJBase 😢

@ablaom
Copy link
Member Author

ablaom commented Aug 13, 2023

In work on MLFlow integration we see that we need such a function. So opening a new issue to add a params2 which in the next breaking release replaces params (but which is not to be exported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General
priority low / straightforward
Development

No branches or pull requests

1 participant