Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload MLJModelInterface.fitted_params to get more readable fitted_params(mach) output #35

Open
ablaom opened this issue Jan 25, 2023 · 0 comments
Open

Overload MLJModelInterface.fitted_params to get more readable fitted_params(mach) output #35

ablaom opened this issue Jan 25, 2023 · 0 comments
Labels
next breaking release
Projects
General

Comments

@ablaom
Copy link
Member

ablaom commented Jan 25, 2023

Here's how things look for the classifier:

julia> fitted_params(mach)
(fitresult = (Booster(), CategoricalArrays.CategoricalValue{String, UInt32} "setosa"),)

Rather we should return something like (core_booster=..., encoding=...). The format of encoding could match what DecisionTreeClassifier does.

The other two models just have a core_booster.
@ablaom ablaom added this to priority low / straightforward in General Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next breaking release
Projects
General
priority low / straightforward
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom