Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a non layered action #24

Closed
Wikunia opened this issue Aug 1, 2020 · 7 comments
Closed

Have a non layered action #24

Wikunia opened this issue Aug 1, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Wikunia
Copy link
Member

Wikunia commented Aug 1, 2020

Currently we have the problem that the standard font color is black on a white background.
We can change the color in our ground (our normal name for the background function which is called as the first action) but it gets into its own layer such that the color is actually not "leaked" to the other layers.
Unfortunately this is normally what the user expects. It's quite easy to have a keyword argument for this to say:

Action(tframes, ground; layered=false)

(maybe there is a better name for it @TheCedarPrince ? )
and then everything inside that action is available in the outside world. This way it's also possible to make a shift of the coordinate system there if one doesn't like to have the origin being in the middle.

@Wikunia Wikunia added enhancement New feature or request question Further information is requested labels Aug 1, 2020
@TheCedarPrince
Copy link
Member

Perhaps a better name for this might be "Extend Background Features" as it seems like the background should possibly be a special Action of its own with its own set of features. I think it makes sense to have that layered kwarg as a generic functionality for perhaps any Action. However, for the background Action, with how we are thinking about it, we might want to make it its own unique sort of Action. What do you think? It seems like there may be two problems here that are getting mixed together and by breaking them up, we might be able to better tackle them.

@Wikunia
Copy link
Member Author

Wikunia commented Aug 1, 2020

Okay so we might want to have BackgroundAction which has this set to true and we have a kwarg extend_background. I think your name is really too long 😄

@TheCedarPrince
Copy link
Member

😂 I tried. How about "Make BackgroundAction"?

@TheCedarPrince
Copy link
Member

And yea, I agree. That way, we can do unique things with BackgroundAction without it affecting other actions.

@Wikunia
Copy link
Member Author

Wikunia commented Aug 1, 2020

How about in_global_scope or in_global_layer. I like the use of layer as this is what it's actually referring to and people who used Gimp or Photoshop or some others should be able to grasp it easily. Just my thoughts though

@Wikunia Wikunia self-assigned this Aug 1, 2020
@TheCedarPrince
Copy link
Member

I think I like in_global_layer the best because it is more specific and makes me immediately think of the frame layers as opposed to in_global_scope as that conveys more than just layers. Let's go with that kwarg.

@Wikunia
Copy link
Member Author

Wikunia commented Aug 2, 2020

Okay that one is merged to I'll close this.

@Wikunia Wikunia closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants