Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to v2.0.0 #129

Open
3 tasks
hyrodium opened this issue Oct 10, 2023 · 3 comments
Open
3 tasks

Road to v2.0.0 #129

hyrodium opened this issue Oct 10, 2023 · 3 comments

Comments

@hyrodium
Copy link
Collaborator

The following is a list of changes I intended for v1.0.0. However, since that version has already been released, these changes will be targeted for v2.0.0:

  • Remove gausschebyshev
  • Remove besselroots
  • Organize function names etc.
    • For example, FastGaussQuadrature.asy should be renamed to FastGaussQuadrature.gausslegenedre_asy.
    • They (gausslegendre_asy, gausslaguerre_asy, etc.) will be treated as 'non-exported stable API', meaning they won't be exported but are stable for use.
    • Consider adding an _ prefix for purely internal functions, such as underflow_threshold.
@dlfivefifty
Copy link
Member

Removing deprecated functions and changing internal function names can all happen on 1.1

@jishnub
Copy link
Member

jishnub commented Oct 16, 2023

Please don't remove deprecated functions such as gausschebyshev without a breaking change, as these used to be a part of the official API. By default, Julia doesn't warn about the deprecation unless one starts it with --depwarn=yes, so this may confuse users. Is there a pressing need to remove these functions right away anyway?

@hyrodium
Copy link
Collaborator Author

hyrodium commented Oct 16, 2023

changing internal function names can all happen on 1.1

That's right. But I was just planning to make this package more stable before releasing v1.0.0.

Is there a pressing need to remove these functions right away anyway?

No. We can wait for agreement to remove the deprecated functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants