-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change median and mean export, or update documentation #146
Comments
|
I just bumped into this again. I had already forgotten that I needed to do |
A PR to document or reexport |
See #149 for the latter option |
Reopening to document these reexports |
Is there additional documentation required? I thought the fix to re-export now ensures that the existing docs are now aligned with the code. |
Maybe just a remark stating that they're re exported is what I had in mind |
Added the remark and applied some additional edits in #336 |
There's a mismatch between what the documentation suggests and how these functions are exported.
maximum
andminimum
are exported toBase
, whilemedian
andmean
are exported toStatistics
.BenchmarkTools.jl/src/groups.jl
Lines 66 to 69 in 65ef038
The manual does not mention the need for
using Statistics
to get the the remaining two functions to work.The reference guide also suggests that
median
andmean
are exported the same asminimum
andmaximum
.Unsure whether
median
andmean
should be exported toBase
, since this wouldn't extending an existingBase
method.Similar to #143
The text was updated successfully, but these errors were encountered: