Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo? #316

Closed
gdalle opened this issue Jun 13, 2023 · 26 comments · Fixed by #320
Closed

Add logo? #316

gdalle opened this issue Jun 13, 2023 · 26 comments · Fixed by #320

Comments

@gdalle
Copy link
Collaborator

gdalle commented Jun 13, 2023

@cormullion had a logo suggestion for BenchmarkTools.jl which I kinda like

JuliaLang/www.julialang.org#818 (comment)

thoughts?

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 14, 2023

juliaperformance

Done with the following code:

using Luxor

JULIA_COLORS = [Luxor.julia_blue, Luxor.julia_green, Luxor.julia_red, Luxor.julia_purple]

function main()
    Drawing(500, 500, "/tmp/juliaperformance.svg")
    origin()
    squircle(O, 250, 250, :clip, rt=0.3)
    sethue("white")
    paint()

    @layer begin
        translate(0, 200)
        rmin = 150
        rmax = 260
        band = 40

        for n in 1:4
            setblend(blend(O - (240, 0), O + (240, 0), "white", JULIA_COLORS[n]))
            sector(O,
                rescale(n, 1, 3, rmin, rmax),
                rescale(n, 1, 3, rmin, rmax) + band,
                3π / 2 - deg2rad(45), 3π / 2 + deg2rad(45),
                :fill)
        end

        sethue("white")
        setline(25)
        line(O, polar(400, deg2rad(290)), :strokepreserve)
        setline(14)
        sethue("black")
        strokepath()
        circle(O, 30, :fill)
    end

    finish()
    preview()
end

main()

@cormullion
Copy link

Nice job. A version in black could look cool:

juliaperformance-black

@ararslan
Copy link
Member

Love it! Where are you thinking the logo should go? The repository settings allow you to provide an image as a "social media preview" but I have no idea what that actually means. We could add it to the README.

@cormullion
Copy link

cormullion commented Jun 14, 2023

The "social media preview" is the image you get when people link to your site on those social media sites I hear so much about (do people still use Twitter?😱😀), usually a biggish rectangular image.... if there isn't one in settings you get (I think):

Screenshot 2023-06-14 at 17 59 04 copy

You'd probably need to make something bigger than a logo (eg https://github.com/cormullion/Karnak.jl )

Sometimes there's a place for icon + link: eg on the Julia home page:

Screenshot 2023-06-14 at 18 00 50

Then there's the Documenter documentation - which has options to show and switch between light and dark mode logos.

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 15, 2023

Yeah I was thinking social media preview + docs, and possibly readme. The only issue with the readme is that you can't adapt to the light/dark theme?

@cormullion
Copy link

You can:

JuliaLang/julia#49544

  • especially if Kristoffer approves of it 😛

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 15, 2023

I don't have access to the repo settings for the social media preview. @vchuravy gimme the power?

@gdalle gdalle mentioned this issue Jun 15, 2023
@gdalle
Copy link
Collaborator Author

gdalle commented Jun 15, 2023

Does anyone know why the Readme logo fails to show up?

@gdalle gdalle reopened this Jun 15, 2023
@cormullion
Copy link

line 1 of readme doesn’t look like HTML code?

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 15, 2023

line 1 of readme doesn’t look like HTML code?

Right, I tried to put the logo next to the title and it worked in the markdown preview of VSCode so I didn't think twice

@gdalle gdalle closed this as completed Jun 15, 2023
@ararslan
Copy link
Member

I can add the social media preview. Looks like the images here are square but the section in the settings says:

Images should be at least 640×320px (1280×640px for best display).

Indeed, putting the square one in there crops the height to fill the width. Does someone want to make a wide version?

@cormullion
Copy link

don’t tempt me …

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 15, 2023

I am hereby tempting you

@gdalle gdalle reopened this Jun 15, 2023
@cormullion
Copy link

benchmarks-social-media-preview

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 16, 2023

You gave in to temptation

@ararslan
Copy link
Member

Apologies for the delay. The fruit of @cormullion's temptation has been set as the social media preview. What's left to consider this issue complete? Adding the logo to the Documenter styling?

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 28, 2023

The logo is already in the docs so we can probably close. I'm still a bit confused as to what "Benchmarks.jl" stands for in the social media preview though, isn't it a little misleading regarding the actual name of the package?

@cormullion
Copy link

Oops - I completely overlooked that mistake ... 😱 I'll redo it tomorrow if that's OK...

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 28, 2023

@cormullion, casually renaming core packages since 2023

@cormullion
Copy link

haha - well it really should be Benchmarks, but it superseded an older package with that name already taken, hence the Tools. The rich texture of history ... 😀

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 28, 2023

Honestly that's half of the reason why I work so hard to make Graphs.jl succeed, it's cause we finally have the right name 🤣

@cormullion
Copy link

I hope to not see GraphsNext.jl ...

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 28, 2023

I hope to not see GraphsNext.jl ...

You just gave me nightmares.

But if all goes well you may not even need to see MetaGraphs(Next).jl ever again

@cormullion
Copy link

benchmarks-social-media-preview

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 29, 2023

@ararslan here we go ^^

@ararslan
Copy link
Member

Alright, replaced with the updated one 👍

@gdalle gdalle closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants