Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag non-breaking release of BenchmarkTools.jl? #344

Closed
gdalle opened this issue Nov 20, 2023 · 5 comments
Closed

Tag non-breaking release of BenchmarkTools.jl? #344

gdalle opened this issue Nov 20, 2023 · 5 comments

Comments

@gdalle
Copy link
Collaborator

gdalle commented Nov 20, 2023

Since the last release, there have been 3 commits that I deem possibly breaking:

In my view, semantic versioning is slightly looser when it comes to dev-facing packages like BenchmarkTools.jl, and so we could tag a non-breaking release. What do other people think?

@gdalle
Copy link
Collaborator Author

gdalle commented Nov 20, 2023

PS: I tried to maintain this package for a while but I clearly don't have the bandwidth, so once I get those changes release I'll step aside for a good long while

@KristofferC
Copy link
Contributor

removes an #332 (comment) export so probably ok

Looking at https://juliahub.com/ui/Search?q=leaves&type=symbols&u=use I don't see any use of (the relevant) leaves without explicitly using BenchmarkTools prefix.

@gdalle
Copy link
Collaborator Author

gdalle commented Nov 21, 2023

then I propose we release 1.4.0

@gdalle
Copy link
Collaborator Author

gdalle commented Dec 4, 2023

doing it now since there has not been an objection

@gdalle
Copy link
Collaborator Author

gdalle commented Dec 4, 2023

@gdalle gdalle closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants