New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeout measures warmup (eliminating many of the reasons to use timeout) #368

Closed

willow-ahrens opened this issue May 3, 2024 · 1 comment

Collaborator

willow-ahrens commented May 3, 2024

The issue is with these lines here:

BenchmarkTools.jl/src/execution.jl

Lines 113 to 117 in 0941fd1

    
           start_time = Base.time() 
        
           trial = Trial(params) 
        
           if warmup 
        
               b.samplefunc(b.quote_vals, Parameters(params; evals=1)) #warmup sample 
        
           end

The problem is that we time out if the warmup takes a long time, because we start the clock before the warmup

willow-ahrens mentioned this issue

Run gcscrub after warmup and remove unnecessary gc run for first sample #367

Merged

Collaborator Author

willow-ahrens commented May 3, 2024

Closed in #367

willow-ahrens closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment