Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider storing metadata in the results #24

Closed
KristofferC opened this issue Jul 15, 2017 · 1 comment
Closed

Consider storing metadata in the results #24

KristofferC opened this issue Jul 15, 2017 · 1 comment
Assignees
@KristofferC
Labels
enhancement

Comments

@KristofferC
Copy link
Collaborator

Right now the results being stored are "naked" BenchmarkGroup. I suggest we instead store our own PkgBenchmarkGroup object that wraps a BenchmarkGroup but where we are free to add arbitrary metadata that can be used for e.g. exporting the results. This could include things like the date and hardware for the benchmark.
@KristofferC KristofferC self-assigned this Jul 15, 2017
@KristofferC KristofferC mentioned this issue Jul 15, 2017
Closed
@shashi
Copy link
Collaborator

shashi commented Jul 16, 2017

Nice idea. We could just save 2 BenchmarkGroups in the JLD -- one with the results one with the metadata and mirrors the structure of the results group. BenchmarkGroups can contain anything iiuc. Good to avoid wrapping all operations defined on it.

@KristofferC KristofferC mentioned this issue Jul 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristofferC KristofferC

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shashi @KristofferC