New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-issue: current issues with the coverage
job
#188
Comments
Are coverage files actually uploaded for PRs? None of these seem to be? https://app.codecov.io/gh/JuliaLang/julia/pulls I want to see if JuliaLang/julia#46403 works |
We do not upload coverage on PRs, because coverage takes 3-4 hours to run. You can make a PR to this repo, and in the PR, you set it to use your custom branch of Julia instead of the master branch of Julia. I don't actually remember where you specify your custom branch name, but @staticfloat or @brenhinkeller will know. |
Makes sense! This is me trying. Although I think it might hit a build bug on non-macos that I can't figure out.. |
Sounds like you may have figured it out but FWIW re @dilumalthuge's point IIRC one way to pick a custom branch might be to set |
Here is the old script that addressed most of these issues in buildbot https://github.com/JuliaCI/julia-buildbot/blob/96f24ff3fcfff05c5411662363483271d364ee59/master/coverage.py#L23-L24 |
bump? |
Items 1 and 3 have been fixed. |
2 and 4 I just confirmed are still problems. |
Looking at https://app.codecov.io/gh/JuliaLang/julia/commit/c4fd8a48383235e818c44231d7507168c27f393b/tree/stdlib, 4 seems to have been fixed. |
https://codecov.com/gh/julialang/julia/tree/2a9f4412a00cbaf366895083f651d5d7906cce1f the extraneous file is also gone |
Coverage dropped back down to ~89%. Looks like we can close this! |
This is a great step! But there seem to be a few issues still, looking at https://app.codecov.io/gh/JuliaLang/julia
base/
prefix, so the coverage tools can't find them in the repo. This means that you can't view the source code files on the Codecov website.stdlib/
prefixed https://codecov.io/gh/JuliaLang/julia/tree/master/cache/build/default-amdci5-7/julialang/julia-master-scheduled/usr/share/julia/stdlib/v1.9JuliaLang/julia
repo) are getting included in the statsamend_coverage_from_src!
step is being skipped, though it is hard to compare what changed currently do to previous issuesOriginally posted by @vtjnash in #136 (comment)
The text was updated successfully, but these errors were encountered: