-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DisjointSets to DisjointSet ? #579
Comments
@c-p-murphy did you ever make a PR to do this? |
Hey @oxinabox—no, sorry, things got hectic this past semester with everything going on in the world and I lost track of it. I'll try to finish putting something together over the next week or so and then submit a PR. Thanks for the reminder. |
Cool I might hold off releasing 0.18 for this so can get the deprecations in. |
@c-p-murphy any update? I wouls still like to get this in before tagging 0.18 |
Already fixed by #700 |
The fact that DisjointSets is a collection of sets under the hood is not relevent to the user.
The API is that of a
AbstractSet
.The implementation is a implementation detail that is actually completely invisible to the user AFAICT
The text was updated successfully, but these errors were encountered: