Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DisjointSets to DisjointSet ? #579

Closed
oxinabox opened this issue Feb 10, 2020 · 5 comments
Closed

Rename DisjointSets to DisjointSet ? #579

oxinabox opened this issue Feb 10, 2020 · 5 comments
Milestone

Comments

@oxinabox
Copy link
Member

The fact that DisjointSets is a collection of sets under the hood is not relevent to the user.
The API is that of a AbstractSet.
The implementation is a implementation detail that is actually completely invisible to the user AFAICT

@oxinabox
Copy link
Member Author

oxinabox commented Jun 3, 2020

@c-p-murphy did you ever make a PR to do this?
I can't find it

@c-p-murphy
Copy link
Contributor

Hey @oxinabox—no, sorry, things got hectic this past semester with everything going on in the world and I lost track of it. I'll try to finish putting something together over the next week or so and then submit a PR. Thanks for the reminder.

@oxinabox
Copy link
Member Author

oxinabox commented Jun 3, 2020

Cool I might hold off releasing 0.18 for this so can get the deprecations in.
cf #577

@oxinabox
Copy link
Member Author

@c-p-murphy any update? I wouls still like to get this in before tagging 0.18

@nickrobinson251 nickrobinson251 added this to the 1.0 milestone Sep 4, 2020
@laborg
Copy link
Collaborator

laborg commented Oct 4, 2023

Already fixed by #700

@laborg laborg closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants