Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-broadcasted addition #417

Closed
olof3 opened this issue Dec 24, 2020 · 0 comments
Closed

Non-broadcasted addition #417

olof3 opened this issue Dec 24, 2020 · 0 comments

Comments

@olof3
Copy link
Contributor

olof3 commented Dec 24, 2020

Splitting of the discussion of non-broadcasted addition from #416.

  1. MIMO system + constant, looks wrong (and could potentially be confusing if 1 is interpreted as something like a UniformScaling).
ss(-ones(2,2), ones(2,2), ones(2,2), zeros(2,2)) + 1

Let's disallow this. @mfalt seems to agree that this is the way to go.

  1. SISO system + constant seems reasonable and should be allowed.
ss(-ones(1,1), ones(1,1), ones(1,1), zeros(1,1)) + 1
  1. Should we allow sys + I? I guess it should only be allowed for square systems sys.

There are other functions like feedback where we want similar behavior. Other functions to add to this list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant