Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved default frequency vector for frequency plots #5

Closed
jcrist opened this issue Feb 12, 2015 · 1 comment
Closed

Improved default frequency vector for frequency plots #5

jcrist opened this issue Feb 12, 2015 · 1 comment

Comments

@jcrist
Copy link
Member

jcrist commented Feb 12, 2015

The current algorithm detects all features (poles and zeros) of the individual channels, and creates a range covering these, expanded to the nearest decades. This approach is ok, but has a few issues:

  1. Resonant peaks can have poor resolution, due to not enough points near the peak. MATLAB accomplishes this by increasing resolution near the peaks.
  2. Expanding the range to the nearest decade doesn't always include enough space. If the feature is near the edge, the steady state may be achieved outside the expanded bounds, making for a poor looking plot.
  3. The current algorithm uses too many points to achieve some level of resolution. This is related to 1. In areas with no features, we don't need a dense sampling.
@KronosTheLate
Copy link
Contributor

I want to connect this issue to #368, as there seems to be large overlap. I do agree with this issue about a higher resolution being an upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants