Number parsing: Allow to specify groupmark
#1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.22% // Head: 90.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
+ Coverage 90.22% 90.32% +0.10%
==========================================
Files 9 9
Lines 2271 2275 +4
==========================================
+ Hits 2049 2055 +6
+ Misses 222 220 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thank you for submitting a PR :) |
This optional argument can be used to parse numbers containing thousand separators. As suggested in the issue referenced below, the implementation just sets `groupmark` in the `Parsers.Options` constructor. Resolves #626
|
I added validation. |
|
Bump :) |
|
As far as I can tell, the very same functionality has been implemented and merged in #1093. Closing this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optional argument can be used to parse numbers containing thousand separators.
As suggested in the issue referenced below, the implementation just sets
groupmarkin theParsers.Optionsconstructor.Resolves #626