Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many missing warnings #1083

Closed
adienes opened this issue Apr 29, 2023 · 3 comments
Closed

Too many missing warnings #1083

adienes opened this issue Apr 29, 2023 · 3 comments
Labels
improvement Improve an existing feature/functionality

Comments

@adienes
Copy link

adienes commented Apr 29, 2023

┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 113. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 114. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 115. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 116. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 117. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 118. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 119. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 120. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 121. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576
┌ Warning: thread = 1 warning: only found 9 / 11 columns around data row: 122. Filling remaining columns with `missing`
└ @ CSV ~/.julia/packages/CSV/b8ebJ/src/file.jl:576

one warning at most is sufficient. definitely not one per row. honestly I would expect this as default behavior so I'd be ok if it didn't warn at all

@jariji
Copy link

jariji commented May 29, 2023

I would rather get a failure by default.

@nickrobinson251 nickrobinson251 added the improvement Improve an existing feature/functionality label May 31, 2023
@quinnj
Copy link
Member

quinnj commented Jun 3, 2023

You can pass maxwarnings=1 if you want

@quinnj quinnj closed this as completed Jun 3, 2023
@adienes
Copy link
Author

adienes commented Jun 3, 2023

@quinnj it's great to have that level of control, but I intended this issue to be about default behavior. Respectfully, I do not think the current behavior is a reasonable default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve an existing feature/functionality
Projects
None yet
Development

No branches or pull requests

4 participants