Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we separate out @linq into separate package? #173

Closed
xiaodaigh opened this issue Sep 27, 2020 · 4 comments
Closed

Can we separate out @linq into separate package? #173

xiaodaigh opened this issue Sep 27, 2020 · 4 comments

Comments

@xiaodaigh
Copy link
Contributor

The @linq macro is just extra noise that takes away focus on the core macros.

Would it make sense to separate it out to a DataFramesMetaLinq.jl? So user can import it if they want, and this lessens the maintenance burden on DataFramesMeta.jl

@pdeffebach
Copy link
Collaborator

Thanks for the issue file.

I agree that @linq is a pain. It's currently holding up #171 because of it's odd mix of macro evaluation and normal parsing.

However I think that we should decide to either deprecate it or keep it in the same package. The implementation of @linq is so tightly knit together with the rest of DataFramesMeta that having it in a separate package would make it very hard to test and maintain. For instance, I would have never caught bugs related to #171 and #163 without @linq being included in the test suite.

If we think @pipe is enough, then I would be okay deprecating. But my sense is that people really like @linq because it lets them avoid typing _, every time.

@pdeffebach
Copy link
Collaborator

As an additional update, @linq was never causing a problem in #171. I was mistaken because I had made a mistake while writing the tests.

@xiaodaigh
Copy link
Contributor Author

xiaodaigh commented Sep 29, 2020

deprecate it

I vote for this. It's a standalone thing and doesn't compose with anything else.

because it lets them avoid typing _, every time.

Can just use Lazy.jl

@pdeffebach
Copy link
Collaborator

Closed, since we now prefer @chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants